Design comparison
Solution retrospective
All feedback welcome thank you advice
Community feedback
- @DrMESAZIMPosted over 2 years ago
Hi Hussein
This was very good work from you. I like what @kombora has said on border issues for mobile views. Since the shape of the design would have changed on mobile view where the flex-direction will be column
If you find this a challenge to resolve let me know and I co do a YouTube video for your mending your project code
Marked as helpful1 - @mubizzyPosted over 2 years ago
Excellent job on this challenge! your report has a few issues though:
- wrap everything in your body in
<main>
or use semantics
2. it is a best practice to use both HTML 5 and ARIA landmarks to ensure all content is contained within a navigational region.
Hope it helps:)...don't forget to mark it as helpful 👍
You can get more details here...click here
Marked as helpful0 - wrap everything in your body in
- @JulienK94Posted over 2 years ago
i don't speak english i have seen your site it's pretty good. first when we pass on mobile preview the border-radius side of the element must change :
- border-radius can be used to define different radius for each specific side of the same element border-radius: 10px 0px 0px 10px; here the first value is for top-left, the 2nd top-right, the third for bottom-right and the last for bottom left
Marked as helpful0 - @JulienK94Posted over 2 years ago
your doc has not been correctly uploaded here so i recommend you this youtube video so you can do it the next time https://www.youtube.com/watch?v=RxJP-uJ_QmQ&t=3s
Marked as helpful0 - @xuseen90Posted over 2 years ago
Thanks your advice 🥰🙏
0@DrMESAZIMPosted over 2 years ago@xuseen90 hi please refer to my YouTube video which I did , as i reviewed your code and made some proposed changes on the link below. For easy access use the YouTube chapters in the video description
https://youtu.be/hn3AemoCYYI
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord