3-column preview card component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hi @Yoseif-Alfiky-1,

  Congratulation on completing another frontend mentor challenge

  Excellent work! I see you have received some incredible feedback. I have some suggestions regarding your solution:

  HTML

  • About <h1>it is recommended not to have more than one h1 on the page . Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility. You can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech). Then you can use <h2> instead of those <h1>.

  • Images must have alt attribute. In this challenge , all the images are decorative. For any decorative images, each img tag should have empty alt="" as you did and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images .

  • Don't capitalise in html, let css text transform take care of that. Remember screen readers won't be able to Read capitalised text as they will often read them letter by letter thinking they are acronyms.

  There are so many repeated style rules , better to use reusable and manageable classes. For example: each box have the same styles , So you can use a class .box for the shared styles, then for each distinct styles like (background color)use another class. .box1, .box2 .box3.

  Aside these, Great work! hopefully this feedback helps.

  Marked as helpful

  0
• 

  nicodes•240

  @nicodes-devPosted over 2 years ago

  You have a background-color in your contact class.

  .contact {
   // other styles
    background-color: azure; 
  }
  

  You need to set a <main> semantic tag inorder to fix your error reports. You can replace the section or wrap it with a main tag and add an id or class to it.

  <main class="main">
     <div class="box">...</div>
    <div class="box">...</div>
    <div class="box">...</div>
  </main>
  

  You also need to add an alt attribute on all of your image tags. This is helpful for screen readers.

       <img src="images/icon-sedans.svg" alt="sedans">
  

  I hope this will help.

  Marked as helpful

  0
• 

  Squashim•350

  @SquashimPosted over 2 years ago

  Hello! If you want to get rid of the blue background color you need to delete background-color: azure from your .contact in styles:

  .contact {
      display: flex;
      justify-content: center;
      flex-direction: row ;
      flex-wrap: wrap;
      background-color: azure <---- it is not needed
  } 
  

  If you have any other questions I'll try to help!

  Keep up the good work!

  Marked as helpful

  0