@PhoenixDev22
Posted
Hi @Yoseif-Alfiky-1,
Congratulation on completing another frontend mentor challenge
Excellent work! I see you have received some incredible feedback. I have some suggestions regarding your solution:
HTML
- About
<h1>
it is recommended not to have more than one h1 on the page . Multiple<h1>
tags make using screen readers more difficult, decreasing your site’s accessibility. You can add a<h1>
withclass="sr-only"
(Hidden visually, but present for assistive tech). Then you can use<h2>
instead of those<h1>
.
- Images must have alt attribute. In this challenge , all the images are decorative. For any decorative images, each img tag should have empty
alt=""
as you did andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images .
- Don't capitalise in html, let css text transform take care of that. Remember screen readers won't be able to Read capitalised text as they will often read them letter by letter thinking they are acronyms.
There are so many repeated style rules , better to use reusable and manageable classes. For example: each box have the same styles , So you can use a class .box for the shared styles, then for each distinct styles like (background color)use another class. .box1, .box2 .box3.
Aside these, Great work! hopefully this feedback helps.
Marked as helpful