3-column card using html and css only

Community feedback

• 

  Nikola D•1,510

  @NikolaD93Posted almost 2 years ago

  Hello there! 👋

  Congrats for completing the challenge! Everything looks great and the code is clean, just keep up with the good work! 🙌

  Hope this was helpful for you!

  Happy holidays! 🎉✌

  Marked as helpful

  1

  ---

  

  AbdulRhman•270

  @Abdo-al-RPosted almost 2 years ago

  @Nikola1232456 thank you very much my friend

  1

  

  ZMB•720

  @ZMBAIGPosted almost 2 years ago

  @Nikola1232456 Thanks

  1
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “car icons” in this component are purely decorative. ⚠️ Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  [MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)

  • The headings in your component are being used incorrectly❌ . Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The anchor tag }will achieve this.

  More Info:📚

  MDN The Anchor element

  • Your CSS Reset is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • Implement a "Mobile First" approach 📱 > 🖥

  Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.

  More Info: 📚

  Mobile First

  • Your content is not fully responsive. 😢 Here is a link to Google Developer’s site that will teach you how make it 100% responsive:

  https://web.dev/learn/design/

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property values. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1

  ---

  

  AbdulRhman•270

  @Abdo-al-RPosted almost 2 years ago

  @vcarames borther thank you very much thats a very rich info .. thanks alot

  0