Design comparison
Solution retrospective
Hello, that's my solution to the challenge! 👨💻
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- It is best practice to use, classes for your naming convention as classes are reusable, making them ideal for CSS styling. IDs on the other hand, are not reusable and are mainly used for JavaScript.
- The headings in your component are being used incorrectly. Since the
h1
heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading since it is reusable and it will give each heading the same level of importance.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1@aandreluisPosted almost 2 years ago@vcarames Thanks for your feedback, I already the corrections in my code 👍👍
1 - @AdrianoEscarabotePosted almost 2 years ago
Hello André Luis, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
I noticed that you used a
button
in which case the best option would be ana
, because in my head when a person clicks on a button written Learn More, he is not confirming a form, or something like, it will be redirected to another page, to Learn More about!to solve this problem do this:
<a href="/" type="button">Learn More</a>
I noticed that you used more than one
h1
in the development of the project, this is not a good practice since we can only have one h1 per page, to inform the main title! change all toh2
The remainder is excellent.
I hope it's useful. 👍
Marked as helpful1@aandreluisPosted almost 2 years ago@AdrianoEscarabote Thanks for your feedback! Yes, I already change my code 👍
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord