3-column preview card component

Community feedback

• 

  James Ebimobowei Osuobeni•160

  @EbibeniPosted almost 2 years ago

  Hi 👋 RHerndz. Good job on completing the challenge! I have some feedback for you if you want to improve your code.

  -. Not all images should have alt text. Car icons are for decoration purposes only, so they can be hidden from screen readers by adding aria-hidden="true" and leaving its alt attribute empty(I see you left yours empty): <img src="./images/icon-sedans.svg" alt aria-hidden="true">

  -. Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

  -. It is given that for Mobile the screen size is 375px. however, yours is set to 628px (actual figure). Your @media (max-width:700px) and @media (max-width:768px) are only for the border-radius and make the size and shape of your cards uneven.

  **IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩 ** I hope you find it useful! 😄 Above all, the solution you submitted is great! Happy coding!

  Marked as helpful

  0

  ---

  

  RGhstx•110

  @rherndzPosted almost 2 years ago

  👋Hola! Un gusto, @Ebibeni muchas gracias por tus observacion y consejos, los pondre en practica en este y en otros proyectos, se te agradece demasiado!😄

  1