Design comparison
Community feedback
- @catherineisonlinePosted almost 2 years ago
Cool solution!
To improve semantics, make sure to wrap the entire code in the main tag not including header or footer tags. It will help to remove report issues and improve accessibility as well.
IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL π€©
1@EricodesenvolvedorPosted almost 2 years ago@catherineisonline Thanks, just yesterday I was thinking of fixing this, but I didn't have time. it's already fixed :)
0 - @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:π
- The βcar images/iconsβ in this component are purely decorative; They add no value. So their
Alt Tag
should be left blank and have anaria-hidden=βtrueβ
to hide them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!ππ
1@EricodesenvolvedorPosted almost 2 years ago@vcarames thanks for your reply, i will tweak the code soon. About the importance of images, I knew about it, although this went unnoticed at the time of writing the code...
0@VCaramesPosted almost 2 years ago@Ericodesenvolvedor
I am glad that I was able to help out!
Keep it up!
1 - To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord