3-column preview card component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @kriShnanshu-saini, some suggestions to improve you code:

  • The car images/icons serve no other purpose than to be decorative; They add no value. There Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • The headings are being use incorrectly. The <h1> Heading can only be used ONCE per page. For this challenge, we are assuming that is it part of larger website. So your safe option is to use the <h2> Heading, because it will give each card the same level of importance and it's reusable.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  • While having interactive content (cards, links, icons, buttons, etc…) can definitely make content less static, if not done properly, it can actually have negative effect on your users experience. By simply just applying a “hover” effect to your content, you’re assuming that every device is compatible with “hover” effects. Unfortunately, most devices are not. To provide your users a better experience, you can use the @media (hover: hover) . Now users that that are devices that are not “hover” compatible will be able to enjoy your content.

  More info:

  https://css-tricks.com/solving-sticky-hover-states-with-media-hover-hover/

  https://youtu.be/uuluAyw9AI0

  • For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

  More Info:

  https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9

  https://uxdesign.cc/why-designers-should-move-from-px-to-rem-and-how-to-do-that-in-figma-c0ea23e07a15

  Happy Coding!

  Marked as helpful

  0

  ---

  

  anshuL.saini•60

  @kriShnanshu-sainiPosted about 2 years ago

  @vcarames Looks like i need to work a lot more than I thought on my CSS and some other stuff. Thanks for letting me know about all these sir, I'll make sure to keep this in mind from now on. ❤️

  0