3-column preview card component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 1 year ago

  Hello there! 👋

  You do not need to have visually <h1>. This is only a component, not a full webpage.

  If you want to have it then grab the styling from the following website.

  How-to: Hide content - The A11Y Project

  This is better than what @0xAbdulKhalid has recommended because it does not move the visually hidden element outside the viewport. This means, your website will not have an overflowing issue.

  Here are some suggestions for improvements.

  • Remove all <div class="img"> and <div class="title"> elements. The spacing or the width of the elements inside the <section> should be controlled with the padding of the <section>.
  • Never use px unit for font sizes. Use rem or em instead. Relative units such as rem and em can adapt when the users change the browser's font size setting. Learn more — Why you should never use px to set font-size in CSS

  I hope this helps. Happy coding! 😄

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  ---

  • This solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0