3 Column Preview Card Component using Flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  HTML:

  • You must use a level-one heading (h1) even though this is not a full-page challenge. You can create an '<h1>' element within your 'main' element that will be hidden visually but visible and readable by screen readers. The class "sr-only" hides content visually and here are the styles to copy. e.g.: <h1 class="sr-only">3-column preview card component</h1>

  • You should use the <a> tag instead of the <button> tag because the Learn More button is a link to another page. Use buttons to perform actions like submitting a form or closing a modal and use links to navigate to another page. You can read more about this here.

  CSS:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding and Happy New Year! 🎉🎊🎁

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Add aria-hidden attribute aria-hidden= "true" to the icon img tags to fix the error issue. sample <img src="./images/icon-suvs.svg" aria-hidden = "true"> repeat this for the rest. The content must have one <h1> to fix the accessibility issue. click here for more on web-accessibility

  To center the main on the page using flexbox, add min-height: 100vh to the body. Reduce the max-width of the main for it to be equivalent to the design. You forgot to give the body a background color.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0