3-column-card | Flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • You should use the <a> tag instead of the <button> tag because the Learn More button is a link to another page. Use buttons to perform actions like submitting a form or closing a modal and use links to navigate to another page. You can read more about this here 📘.

  • Not all images should have alt text. Car icons are for decoration purposes only, so they can be hidden from screen-readers by leaving its alt attribute empty.

    You can read more about this here 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1
• 

  Bruno Victor•110

  @bvictor-aPosted almost 2 years ago

  Hi @MelvinAguilar Thank you for your feedback. About the 'button' element I had never thought of it that way, thanks for the explanation. And under the icons I put a description why I thought the accessibility report would throw one more warning. Thank you for your review, it helped me a lot 😄. Excuse me if my answer has any errors by google translate.

  0