Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

i used bootstrap for the most parts of the project

maryan 420

@Maryan121

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


any feedback ?

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hello maryan, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written learn more, he is not confirming a form, or something like, it will be redirected to another page, to learn more about!

to solve this problem do this:

<a href="/" class="mt-lg-4 btn3 rounded-pill">learn more</a>

I noticed that you used more than one h1 for this component, this is not considered a good practice since we should only have one h1 per page, to inform the main title!

To improve the code structure wrap this div:

<div class="attribution">

with the semantic tag footer

The remainder is excellent.

I hope it's useful. 👍

1

@LucasHMelo

Posted

Hello,

I think your project is great, but you can look for some points, like the allign of the buttons and hover too. Also look for other points, like width and other details.

Congratz

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord