3-column preview card component

Community feedback

• 

  P

  Radek Tomasek•160

  @radektomasekPosted about 1 year ago

  Hello Yaroslav 👋,

  I had some time to have a look at the code and here are some observations/recommendations that you can apply:

  • You might consider using CSS properties to define your variables. If you look at your CSS code, you are duplicating some stuff like colors/fonts. You can reduce that repetition by declaring the properties and then applying them. More info here.

  • You are using absolute units in places where you might consider using relatives ones. A good example is font-size. If you use absolute units (pxs), you are putting some unnecessary barrier for people with accessibility needs. If they change the default font size in the browser settings (making fonts bigger), there won't be any change on your site because of absolute units. You need to use relative units like rem, em ideally. Here is a good article if you would like to learn more.

  Otherwise, well done with the implementation.

  Have a great day. Radek

  Marked as helpful

  1

  ---

  

  Yaroslav•90

  @BisykPosted about 1 year ago

  @radektomasek Many thanks for your feedback. I will use your advice in the future to make my works even better.

  1