Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <div class="container"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .card-holder on the page using flexbox, replace the height in .container with min-height: 100vh and align-items: center to .container.
To center .card-holder on the page using flexbox: .container{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
There is no need to give .card-holder, .contain and .card margin values.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord