3-column preview card component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h1> so it can cause severe accessibility errors due to incorrect usage of level-one headings <h1>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's three <h1> elements, like this <h1>SEDANS</h1>, you can preferably use <h2> instead of <h1>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  • Example: <h1 class="sr-only">3-column preview card component</h1>

  ---

  CSS 🎨:

  • Looks like you declared each background color for each button which needs to be change the background color during the hover, actually we can handle that issue with a the inherit value

  ---

  • Yes you're right there's a value which is used to inherit the parent element's background

  ---

  • So just add background: inherit for the button elements during hover additionally we replacing the border with outline they both work similar but outline doesn't consume extra space like border does.

  ---

  • Let's look an example

  button:hover {
  background-color: inherit;
  color: white;
  outline: 1px solid white;
  }
  

  ---

  • Now you can remove these individual declarations for the background for each button element

  .sedans a:hover {
  background-color: var(--bright-orange);
  border: 2px solid var(--very-light-gray);
  }
  .suv a:hover {
  background-color: var(--dark-cyan);
  border: 2px solid var(--very-light-gray);
  }
  .luxury a:hover {
  background-color: var(--very-dark-cyan);
  border: 2px solid var(--very-light-gray);
  }
  

  ---

  • Now you have gotten the desired result without hassling in an efficient way.

  ---

  • Pro tip: you can use transparent value for background property to get the same effect as `inherit.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1