Design comparison
Solution retrospective
All suggestions and hints are welcome. Thank you. :)
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
DECORATIVE SVG'S β¨οΈ:
- The
alt
attribute is used to provide alternative text for images in HTML documents. Thealt
attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
- Now, when it comes to decorative
SVGs
, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
- Since these images do not convey any important information or functionality, there is no need for an
alt
attribute.
- So feel free to set the
alt
attribute as""
for decorativesvg's
, becausealt=""
will be skipped by screen readers they will consider the image as decoration
Example:
<img src="images/decorative.svg" alt="">
<img src="images/icon-luxury.svg" alt="Luxury-icon"> π <img src="images/icon-luxury.svg" alt="">
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@Ola135Posted over 1 year agoHello @0xAbdulKhalid!
Thank you for the feedback and your time. I'll go through the code and make required changes.
Happy coding to you too! :)
0 - @VCaramesPosted over 1 year ago
Hey there! π Here are some recommendations for enhancing your code:
- The βcar iconsβ in this component are purely decorativeβ οΈ. Their
alt tag
should be left blank to remove them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
- The headings in your component are being used incorrectlyβ. Since the
h1
heading can only be used once β οΈ, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading β since it is reusable and it will give each heading the same level of importance.
- For improved accessibility π for your content, it is best practice β
to use
rem
for yourfont-size
and other property values. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
- ALWAYS Implement a "Mobile First" approach π± > π₯
Mobile devices are now the dominant π way in which people browse the web. So when building your content, you will start building with small screen sizes (starting at 320px) and work your way to larger screens using
min-width
.More Info: π
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! πΎ
Marked as helpful1@Ola135Posted over 1 year agoHello @vcarames!
Thank you kindly for your feedback. It helps a lot.
Could you please explain to me whether it is necessary to use h1 heading at least once in the project or can we skip it and just use h2 heading as you suggested?
Thank you in advance. Happy coding to you too! ^^
1@VCaramesPosted over 1 year ago@Ola135
headings
provide structure the content. Anh1
is always giving to the introductory text in your site to let users know what the page is about. Think about a book; the title is anh1
, the chapters areh2
and everything else is either aparagraph
.- This is a component, something that is meant to be part a larger site. So in the real world it would never have an
h1
. On top of that, since it has multiple headings of equal importance, andh2
will do fine.
Marked as helpful1 - The βcar iconsβ in this component are purely decorativeβ οΈ. Their
- @Nix7amcmPosted over 1 year ago
Hey @Ola135! π
Excellent job with this challenge! π
I have just a couple tips that might be helpful!
First, you might consider setting your breakpoint to something around
920px
, switching to column a little earlier to prevent the box width becoming too small as the screen size narrows.Then, within your query, to prevent the boxes then being too wide, you could set a
max-width
to your.card
element, maybe something around500px
. You could play around with this to see what you like best!I hope this helps! Great work! ππππ»
Marked as helpful1@Ola135Posted over 1 year agoHello @Nix7amcm !
I am grateful for your comment. Thank you for your tips, these will definitely help.
Wish you the best and happy coding! ^^
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord