Design comparison
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:📚
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
to your “car images/icons” to fully remove them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The headings in your component are being used incorrectly. Since the
h1
heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading since it is reusable and it will give each heading the same level of importance.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0 - To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
- @HassiaiPosted almost 2 years ago
Add Box-sizing: border-box to *. To center a content on a page, add min-height:100vh; display: flex; align-items-center: justify-content: center; to the body. Replace the <div class="flex-container"></div> with the main tag. There is no need to give .flex-container margin:150px auto; for the buttons there is no need <div class= "learn ">. Give a text-decoration :none; font-weight:700; padding: 1em 2.5rem: background-color: hsl(31, 77%, 52%); border: none and a border-radius value. give a: hover a border value and color value: a:hover{ border:3px solid white; color: white} Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To Hope am helpful HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord