3-column preview card component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hi @KorsanDev,

  Excellent work! Congratulation on completing this challenge. I have some suggestions regarding your solution:

  HTML

  • Never use <span> alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the span tag unless none of them (the semantic tags) really match the content to group together.By adding semantic tags to your document, you provide additional information about the document, which aids in communication. You can use <h2> instead of <span>

  • In this challenge , all the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" as you did and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images .

  • Imagine what would happen when the user click those learn more?In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.

  Aside these, Great work! Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  KorsanDev•70

  @KorsanDevPosted over 2 years ago

  @PhoenixDev22 Hi, thank you very much, your comment is very helpful.

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @KorsanDev Glad it was helpful. Happy coding!

  1