Hey, nice job, card looks good.
Few suggestions:
- use cursor:pointer; on buttons.
- use border: 1px solid transparent; on buttons this prevents content shift when hovering them.
Good luck ...
Marked as helpful
3
I feel like I did my best on this challenge. But your feedback is always awaited and appreciated.
@muhammadshajjar
Posted
Hey, great work on this one,
a
link, in my opinion, using the a
tag and not a button. Use the button
if it will act as a control for something. But on this, it is treated as a link, go for a
tag.alt=""
and add aria-hidden=" true"
or role=" presentation"
to make sure that all screen readers will ignore those icons.h1
per page. Don't judge heading level by the weight of text given in designwidth
try to go for max-width
. Writing fixed things would cause issues.<main>
<div></div>
</main>
<footer>
</footer>
Thanks, hope it would help!
Marked as helpful
@esthercate
Posted
@muhammadshajjar Thank you. This is very insightful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord