Design comparison
Solution retrospective
My biggest difficulties were with regard to responsiveness, mainly because on mobile the first card was not appearing completely, apparently because of the size of the body. I also had difficulties with the button that was made using the a tag, because I was not able to apply the inline-block to it. Finally I had difficulty choosing which would be the best breakpoint and setting the maximum widths of certain elements.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS ⚠️:
- This solution lacks usage of
<h1>
so it can cause severe accessibility errors due to lack of level-one headings<h1>
- Every site must want only one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
- Example:
<h1 class="sr-only">3-column preview card component</h1>
- If you have any questions or need further clarification, you can always check out
my submission
for this challenge where i used this technique and feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0@samuerikcoderPosted over 1 year ago@0xAbdulKhalid Thank you very much for the tip. I made the modifications, accessibility is essential.
0@0xabdulkhaliqPosted over 1 year ago@samuerikcoder Glad you found it helpful ! 🤠
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord