Design comparison
Solution retrospective
Just going through all the early challenges – any feedback appreciated!
Community feedback
- @MiculinoPosted almost 3 years ago
Congrats on completing the challenge, @hyde-brendan!
Your solution looks and functions well. The features are all working as expected and your code is well-structured and written.
My only suggestion is to use more classes in your HTML code and make sure they're meaningful. You might want to checkout BEM methodology https://en.bem.info/methodology/html/
Marked as helpful1 - @BurritoDoggiePosted almost 3 years ago
Hello!
Beautiful code! It even fits every device! I love the hover effects you added on the buttons! I actually learned something new while looking at your code!
Keep Coding!
:)
(If you found this helpful you can let me know by giving this a thumbs up or by marking this helpful!)
2 - @PhoenixDev22Posted almost 3 years ago
Hello hyde-brendan,
Well done! your solution is really nice. To tackle the issue: •Page should contain a level-one heading. Click here to read more. Overall great work! happy coding.
1@hyde-brendanPosted almost 3 years ago@PhoenixDev22 Hi! Thanks for the feedback – I was using
<h2>
for the titles because apparently using multiple<h1>
tags isn't considered a good practice? That and because I figured the content here practically would be a component for a main page, which would already have its own<h1>
.I'll be sure to keep this in mind going forth 👍
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord