Design comparison
SolutionDesign
Solution retrospective
Here is my Solution for the Challenge . All Feedbacks are Welcome. Thankyou.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- Do not forget β οΈ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
- Along with the blank
alt tag
, you also want to include thearia-hidden=βtrueβ
β οΈ to your βcar images/iconsβ to fully remove them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
- Do not capitalizeβ "sedans", "suvs" and "luxury" in HTML as it is not accessible friendly. Instead you will want to style it in CSS.
- The "sedans", "suvs" and "luxury" are headings β οΈ so they need be wrapped in a heading element. Since each heading in this card has the same level of importance an
h2
heading β will be the best choice.
- Your
CSS Reset
is being underutilized. π’ To fully maximize π― it, you will want to add more to it.
Here are some examples that you can freely use:
- Implement a "Mobile First" approach π± > π₯
Mobile devices are now the dominant π way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.
More Info: π
- For improved accessibility π for your content, it is best practice to use
em
formedia-queries
. Using this unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! πππͺ
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord