3 Column Preview Card

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Every site/component should always have ✅ a main element not only for semantic purposes but also help assistive technology find the main content of your content. For this challenge, it will serve as your components container ⚠️.

  More Info: 📚

  MDN Main Element

  • The attribution ⚠️ should be wrapped inside a footer element for improved semantics.

  • The “car icons” in this component are purely decorative. ⚠️ Their alt tag should be left blank.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The headings in your component are being used incorrectly❌ . Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The anchor tag }will achieve this.

  More Info:📚

  MDN The Anchor element

  • NEVER ❌ do this as it creates accessibility issues for users and it is outdated, instead download a px to rem/ em converter in your code editor.

  html {
    font-size: 15px;
  }
  

  • Your CSS Reset is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset

  • To properly center ✅ your content to your page, you will want to add the following to your body (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info: 📚

  Centering in CSS

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1

  ---

  

  chicaboom-73•50

  @chicaboom-73Posted almost 2 years ago

  @vcarames Thank you there was a lot there for me to review. I will definitely be reading through your recommendations. Appreciate the feedback a lot. I haven't looked at CSS grid yet, but I want to start learning and using it. Thank you :)

  0

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  @chicaboom-73

  Glad I could help! 😁

  Once you learn grid, it will make things way easier.

  Marked as helpful

  0