Submitted almost 2 years ago
HTML5 | CSS | Mobile First | CSS Custom Properties | Flexbox
@Hazel-Black
Design comparison
SolutionDesign
Solution retrospective
Started this project months ago. I realized this morning I never submitted it so I decided to solve some of the issues I had with the css and submit it. Any and all Suggestions for improvements are welcome. π€
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- The βcar iconsβ in this component are purely decorative. β οΈ Their
alt tag
should be left blank and have anaria-hidden=βtrueβ
to hide them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
- Your "buttons" were created with the incorrect element β. When the user clicks on the button they should be directed to a different part of you site. The
anchor tag
}will achieve this.
More Info:π
- Your
CSS Reset
is being underutilized. π’ To fully maximize π it, you will want to add more to it.
Here are some examples that you can freely use:
- For improved accessibility π for your content, it is best practice to use
rem
for yourfont-size
and other property value. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!ππ
0 - The βcar iconsβ in this component are purely decorative. β οΈ Their
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord