3-column preview card component

Community feedback

• 

  Adriano•38,120

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Mads Gregersen, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  To make your page more like the example layout, we can do this:

  body {
      background-color: #F2F2F2;
  }
  

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Mads Gregersen•30

  @ByProxy66Posted almost 2 years ago

  @AdrianoEscarabote I totally missed that background color. I changed the font size. Nice tip with the extension. Thanks.

  1

  

  Adriano•38,120

  @AdrianoEscarabotePosted almost 2 years ago

  @ByProxy66 happy coding!!

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  In the body you can specify display:flex; , text-align: center , justify content center, min-height: 100vh, margin 0 auto; to center the content, then specify padding top , bottom . Since the image is already in a div , give the div a padding value for all the sides by specifying that in the class="Product". You did the mobile design first so there is no need to declare display flex in the container. Apart from these everything is good. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Mads Gregersen•30

  @ByProxy66Posted almost 2 years ago

  @Hassiai Thank you very much for the feedback. What I'm reading is that the container is basically redundant?

  0

  

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  @ByProxy66 the container is not redundant, you specify margin-top for the images while you can use a padding-top of padding: 2em 0; in the class product. then you declare margin-bottom for the logo-image for the space between the image and the heading. Hope this helps out.

  1