Design comparison
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
to your “car images/icons” to fully remove them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The headings in your component are being used incorrectly❌ . Since the
h1
heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading since it is reusable and it will give each heading the same level of importance.
- Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The
anchor tag
will achieve this.
More Info:📚
- Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0@TheRequiemPosted almost 2 years ago@vcarames Thanks. I'll take everything into consideration and they make sense but the link that you provided doesn't mention
aria-hidden=“true”
but only mentions that thealt=" "
be used for decorative images!1@VCaramesPosted almost 2 years ago@TheRequiem
Glad I could help!
Sorry about that m. I recently updated the resources I was using.
Here’s the correct on that explains the
aria-hidden=“true”
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description
1 - Along with the blank
- @HassiaiPosted almost 2 years ago
To center the main on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body. instead of giving the main a margin value.
There is no need to give the columns a padding bottom value , reduce the padding value to 3rem.
Hope am helpful
Well done for completing this challenge. HAPPY CODING.
1@TheRequiemPosted almost 2 years ago@Hassiai It only centers it vertically but it is still better than using a vertical margin, I found out that setting
margin: 0 auto;
to center it horizontally andalign-items: center;
vertically. I also setmin-height: 90vh;
instead of100vh
as you suggested because it overflows the<footer>
. But yes, this hybrid method is better than what I was initially using to center, thanks! As for the padding, I'll confess that I was lazy when I was setting@media
queries and I didn't notice the extra padding on the bottom and that my icons are smaller until I uploaded the solution!0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord