Design comparison
Solution retrospective
Hello Coders,
This my first project and i hope to get some feedback on how to improve my code. I always struggle to pick the correct class names. Also having trouble picking the right HTML tags. I looked to some other examples and they use for example <section> tags.
I'm also curious what you think of my css code.
Greetings, Danny
Community feedback
- @tesla-ambassadorPosted over 2 years ago
Hey DVBENTHEM, congratulations on completing your first frontend mentor challenge! I hope you had fun doing this π About the class names, don't worry, that happens to almost everyone you'll be surprised by how people name their classes π Also, on the point of HTML tags, you just need to read a little more on the essential HTML tags on (this link)[https://developer.mozilla.org/en-US/docs/Web/HTML] the more you write HTML code is the more you are able to discern which tag to use in a certain instance.
- In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like
<main>
or<header>
or<footer>
you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link.
Happy coding and keep up the good work!
Marked as helpful2@dvbenthemPosted over 2 years agoHello @tesla-ambassador thanks for your reply. I for sure had a lot of fun coding this challenge. I'm already working on the next challenge :).
Thank you for the link on HTML tags and for the landmarks. I'll get to work on it right away. I will try to correct the errors i made.
Thanks again!
1@tesla-ambassadorPosted over 2 years ago@dvbenthem You're welcome! I am glad I was of help.
0 - In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord