3-column preview card component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello Gelcimar, You have done a good work! 😁

  Some little tips to improve your code:

  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of buttons
  • add transition on the element with hover effect
  • Tip of graphic design: with font-family:" Big Shoulders Display ", cursive the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with a font-family:" Big Shoulders Display ", sans-serif much more similar to the primary font.

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Gelcimar Moraes•150

  @GelcimarMoraesPosted about 2 years ago

  @denielden Thank you for your feedback! I updated my code with your tips.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @GelcimarMoraes you are welcome and keep it up :)

  1
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @GelcimarMoraes, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  1.Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  2.Use max-width: 100% for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).

  3.Add the correct color for the background, that in this case is background-color: #F2F2F2

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Gelcimar Moraes•150

  @GelcimarMoraesPosted about 2 years ago

  @correlucas Thanks, I will follow yours recommendations.

  0