Design comparison
Solution retrospective
Here's my fourth challenge here. Everyday I think my code skills is really improving. Thankyou for this community!
Consistent learner.
Community feedback
- @HassiaiPosted almost 2 years ago
Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility
To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
Give .container a fixed max-width value in the mobile design
max-width: 400px
and a fixed width valuewidth: 900px
in the desktop design(media query). There is no need to give h1 a font-size and reduce the margin value of pp{margin-bottom: 30px;}
.Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units. click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord