Design comparison
Community feedback
- Account deleted
Hi
The way you have your markup saved makes it very difficult to read, there is no reason to have it spaced out to that extent. Pages must have a level 1 heading <h1> and you must not skip level headings meaning yo cannot go from an <h2> to a <h4> and a page can have multiple <h1> headings, change your <h2>'s to <h1>. I think you have to many container elements, I do not see any need for <article>, you could have made <main> your card container and also you should have made body a flex container and used justify-content and align-items so that card container is centered nicely. You also need to give <html> and <body> a height of 100%.
In your style sheet it is recommended to save custom variables in <root>, eg.
:root { --bright-orange: hsl(31, 77%, 52%); }I hope this helps
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord