@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Unless your company requires you to use a library , I strongly suggest you stay away from using libraries until you fully grasp the fundamentals of HTML, CSS and JS. By using a library, you are robbing yourself from actually learning how to code.
- The “car images/icons” in this component are purely decorative; They add no value. So their
Alt Tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The
attribution
should be wrapped in afooter
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful
@vcarames Thanks for the feedback! I chose the library cause I know how raw CSS works. So I moved on and want to adopt new technology.
- Thanks again for mentioning the "car images". It was in shape, so I didn't focus on it. Next time, I won't skip.
@VCarames
Posted
@m-rokon
Glad I could help!
If you are comfortable with the fundamentals, learning a library is the next best thing.They can help, when time is of the essence.
Unfortunately, a lot people will skip and jump straight to a library since it does all the heavy lifting.
Keep it up!