@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- The “car icons” in this component are purely decorative. Their
alt tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The
anchor tag
}will achieve this.
More Info:📚
- To properly center your content to your page, you will want to add the following to your
body
(this method uses CSS Grid):
body {
min-height: 100vh;
display: grid;
place-content: center;
}
More Info:📚
- Implement a Mobile First approach 📱 > 🖥
Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks presentable on all mobile devices.
More Info: 📚
- For improved accessibility 📈 for your content, it is best practice to use
rem
for yourfont-size
and other property value. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful
@simonmatt89
Posted
Thank you for this feedback! @vcarames