Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3 column preview card component

Simon 20

@simonmatt89

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my 2nd project that I have completed with Front End Mentor. This time, I hope I have improved my use of sementic HTML code. I do wonder if my CSS code could be more efficient? I'm looking forward to checking out other's solutions so I can compare my code.

I also find it easier to create a mobile site than I did previously. I was able to create this project much faster than the last which makes me happy!

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • The “car icons” in this component are purely decorative. Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

More Info:📚

https://www.w3.org/WAI/tutorials/images/

  • Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The anchor tag }will achieve this.

More Info:📚

MDN The Anchor element

  • To properly center your content to your page, you will want to add the following to your body(this method uses CSS Grid):
body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

More Info:📚

Centering in CSS

  • Implement a Mobile First approach 📱 > 🖥

Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks presentable on all mobile devices.

More Info: 📚

Mobile First

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-sizeand other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!🎄🎁

Marked as helpful

1

Simon 20

@simonmatt89

Posted

Thank you for this feedback! @vcarames

0

@Mohammedabbas7

Posted

Congratulation on completing the second project 🎉. I have a few adjustments that I wanna show it to you.

  • replace the <div> tag with <footer> tag on the attribution section because it has semantic meaning.
  • you forgot the hover state on the Learn More buttons. you can add these properties to the button element
button {
display: inline-block;
    background-color: "color that you choose";
    color: #333;
    padding: .8rem 1.5rem;
    border: 1px solid "color that you choose";
    border-radius: 2rem;
    transition: all .2s;
}

for the hover state you can add these properties:

button:hover {
    background-color: transparent;
    color: "color that you choose";
}

well done on this challenge and happy coding on the next challenge 👍.

Marked as helpful

0

Simon 20

@simonmatt89

Posted

Much appreciated - thanks for the feedback! I didn't include the hover state as the design spec stated it as an 'active state'. @Mohammedabbas7

0

@Mohammedabbas7

Posted

@simonmatt89 You are welcome 😊.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord