Melvin Aguilar π§π»βπ»β’ 61,140
@MelvinAguilar
Posted
Hi there π. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.
HTML:
- You should use only one
<h1>
tag per page. The<h1>
tag is the most important heading tag, This can confuse screen reader users and search engines. This challenge requires thatSedans
,SUVs
andLuxury
are headings, but you can use the<h2>
tag instead of the<h1>
tag. You can read more about this here.
- Not all images should have alt text. Car icons are for decoration purposes only, so they can be hidden from screen-readers by adding
aria-hidden="true"
and leaving its alt attribute empty:
<img src="./images/icon-sedans.svg" alt aria-hidden="true">
<img src="./images/icon-suvs.svg" alt aria-hidden="true" >
<img src="./images/icon-luxury.svg" alt aria-hidden="true" >
CSS:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.
- You should use a CSS reset to remove the default browser styles and make your page look the same in all browsers.
Popular CSS resets:
Please don't worry if your suggestions are long, they are just details. In the end, the project is well done π. Hope you find those tips helpful! π
Happy coding! πππ
0
Zulfa Nurfajarβ’ 70
@zulfaan
Posted
@MelvinAguilar Hi, thank you for your respond. I'm still learning how to use CSS and your feedback is really helpful.
0