FLEX||GRID

Community feedback

• 

  Nelson•2,390

  @nelsonleonePosted almost 2 years ago

  HELLO......congrats on completing this challenge .....well done 🎊 🎊

  i just have one thing to say , It's based on the little car images. Visually , they don't send much message(for design purposes).

  It would be nice to set aria-hidden="true" on them so screen-readers(AT) won't stress on what they are. Thereby increasing your solution accessibility rate.

  Hope this comment was helpful, have fun coding

  Marked as helpful

  1

  ---

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @nelsonleone

  Thank you for contributing to the FEM community.

  As a friendly reminder, please avoid repeating what already has been mentioned. To better improve the effectiveness of the feedbacks.

  Happy Coding! 🎆🎊🪅

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “car icons” in this component are purely decorative. ⚠️ Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  MDN Aria-Hidden

  • The headings in your component are being used incorrectly❌ . Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The anchor tag }will achieve this.

  More Info:📚

  MDN The Anchor element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1

  ---

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  • The web development process can be made easier and expedite the process 🚀 by implementing a CSS Reset.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.

  • Implement a "Mobile First" approach 📱 > 🖥

  Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.

  More Info: 📚

  Mobile First

  Marked as helpful

  1

  

  Nelson•2,390

  @nelsonleonePosted almost 2 years ago

  @vcarames what did i do ?

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @nelsonleone

  Please read the comment that I left. It provides the answer to your question.

  0

  

  Nelson•2,390

  @nelsonleonePosted almost 2 years ago

  @vcarames i meant personally , did i offend you ?

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @nelsonleone

  How did you interpret what I said?

  0