@correlucas
Posted
👾Hello @ayakilany, Congratulations on completing this challenge!
Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:
Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.
Fix the alignment. The best way make this alignment is by using FLEXBOX. The first step, is to add min-height: 100vh to make the body height size becomes 100% of the viewport height, this way you make sure the container will be aligned vertically since the body will display ever 100% of the screen height. After that add two flex properties to make the alignment display: flex / align-items: center; / justify-content: center;. If you're using the attribution you need to add flex-direction: column to make the attribution stays under the QR Code component. See the code below:
body {
min-height: 100vh;
background-color: hsl(0, 0%, 95%);
color: hsl(0, 0%, 95%);
font-size: 15px;
font-family: 'Lexend Deca', sans-serif;
display: flex;
align-items: center;
justify-content: center;
}
✌️ I hope this helps you and happy coding!
Marked as helpful
