Design comparison
SolutionDesign
Community feedback
- @correlucasPosted about 2 years ago
Hello Raja, congratulations for your solution!
You can use
main
to wrap the main block of content andarticle
for each card, and use a class to manage the cards characterist and other one to manage the single cards like colors.This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
I hope this helps you, keep coding!
Marked as helpful0 - @denieldenPosted about 2 years ago
Hello Raja, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - remove descriptive text in the
alt
attribute of the icon images because only decorative - remove all
margin
from.main-container
class - after, add
min-height: 100vh
to.main-container
class because Flexbox aligns child items to the size of the parent container - Tip of graphic design: with
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with afont-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font. - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord