Design comparison
Solution retrospective
Hello Everyone,
I would love feedback on this project, to see how I am progressing.
Thanks
Jon
Community feedback
- @EngineerHamzieyPosted over 2 years ago
I have done some some correction and explanation to someone's code you can check it, it will help...
if you notice anything wrong, feel free to contibrute/correct me I am not perfect, I am a beginner, I am open to correction and suggestions and I wiling to learn more I'm doing this because I hope it will help
feel free to ask questions,
0@JonhilluppertonPosted over 2 years ago@EngineerHamziey
Thank you for the comment, but some areas of what you have said don’t need to be apply, on the one you commented on you didn’t mention about min-height:100vh to the body and you place rem on the img’s width, to me the images are the sized as they are svg’s when you look at the code they have a size already placed inside them. Reason I chose a button over a link as I believed it was a button as it does still carry out a act, but instead of putting an a tag within a button tag which you can’t do, I put a onclick piece in to say go to this page.
Thanks
Jon
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord