3-Column Layout w/ Flex and Grid

Community feedback

• 

  Candela Bramucci•680

  @bramuccciPosted over 3 years ago

  Hey, this is pretty awesome! The only things I want to say is that the padding in .preview-card-section is a little arbitrary, I think 3rem is better. And don't use border-radius in individuals card, instead .preview-card { border-radius: 0.5rem } is easy to deal. Again, great work. Keep going~

  Marked as helpful

  1

  ---

  

  James Greilick•50

  @jgreilickPosted over 3 years ago

  Thank you for the feedback @Liltanie! Simplifying the padding definitely makes sense. I have a question about the border-radius though. When I set it on the .preview-card and not the individual sections then I lose the border-radius altogether. Do you know why that is? It seems the individual sections don't conform to the border-radius of their containing element.

  Thanks again!

  1

  

  Candela Bramucci•680

  @bramuccciPosted over 3 years ago

  @jgreilick Oh sorry, I forget to mention. You have to add:

  .preview-card {
    border-radius: 0.5rem;
    overflow: hidden;
  }
  

  And you're welcome! I'm glad this help you.

  1

  

  James Greilick•50

  @jgreilickPosted over 3 years ago

  @Liltanie Thank you!

  Using overflow: hidden; actually occurred to me this morning and I was about to give it a try :)

  I appreciate having the chance to find it for myself. You pointed me in the right direction, and that is perfect mentoring. Keep it up, it's helpful and encouraging!

  1