3-column card with Flex, BEM, HTML5, CSS3

Community feedback

• 

  minthing•145

  @minthingPosted over 3 years ago

  container is not centerd (if the display is bigger than 1552) how about use justify-content: center and remove margin:50px in wrapper class?

  nice work! cheer! ✨

  1

  ---

  

  Art•420

  @Art-wdtPosted over 3 years ago

  @minthing Thanks for the great advice!

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey there, Art! 👋

  Well done on another challenge! 👍 Your solution looks good! 😀

  I'd like to suggest using a less-important heading tags (such as <h2> or <h3>) for the titles of the sections of the card since it's generally considered a best practice to only use a single <h1> tag per page.

  Also, perhaps consider centering things with flexbox (as opposed to margin or padding). In this case, it would make centering the card component in the viewport quite easy, I think! 😉

  Keep coding (and happy coding, too)! 😁

  0