3-column card component

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted over 3 years ago

  Hi

  Well done on getting a challenge done. Here is how I would try to improve this

  • fix mobile landscape. It switches to desktop view for me but with cards very narrow and content hitting the side of the screen
  • remove the header elements. Multiple landmarks would be confusing to screenreader users
  • remove the picture elements. You only use those if serving multiple images so the browser can choose the best one to use for a device
  • change button elements for anchor tags, as learn more would almost certainly trigger navigation
  • only use single class selectors in css not ids or nested selectors
  • change font sizes to rem/em (extremely important not to write font-sizes in pixels)
  • make the buttons like the design (not stretching full width)

  I hope all this helps you. Good luck

  0