3-column Card Component

Community feedback

• 

  Agnar•220

  @agnar-nomadPosted about 2 years ago

  hey Edmond.

  congrats on the solution. I appreciate your class names, they are well descriptive.

  A few notes:

  • your description text needs a little more breathing space, on the other hand, your buttons have too much padding
  • double check the how the headings should look according to the design
  • no biggie, but your <main> could have been the card container, no need for another level of complexity
  • the buttons are supposed to take you to another page, the anchor tag is more appropriate, considering that only CSS is supposed to be used for this task
  • consider using shorthand variants of certain properties, such as margins, border radii and similar

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @Edmond-Wu-9, some suggestions to improve you code:

  • The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  Happy Coding! 👻🎃

  0