Skip to content
Submitted over 1 year ago

3-Column Car preview

Sarmad Khan•310
@Sarmad-Khan-creator
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...3-column preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I took this challenge and try to complete it in a best way possible. Please, have a look it and give me any suggestion how I can improve my coding skills and suggest the best practices for CSS and HTML. Thank you

Community feedback

  • P. Ricardo•2,370
    @pRicard0Posted over 1 year ago

    Some HTML tips

    • You need to improve your semantic. You can use the tag main instead of the div with the main class.
    • You can use section instead of the div with the flex-item class
    • You need to use h1 instead of h2. If your project doesn't already have h1, you can't use h2. You need to respect the hierarchy.
    • Instead of using <a href="#">Learn More</a>... I think using a button makes more sense.

    CSS tips

    • I think you should use rem instead of px
    • You can add transitions to the button to improve the user experience.
    0
    Sarmad Khan•310
    @Sarmad-Khan-creatorPosted over 1 year ago

    Thanks, your suggestions means a lot. @pRicard0

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord