@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
-
To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
Mainelement. -
Along with the blank
Alt Tag, you also want to include thearia-hidden=“true”to your “car images/icons” to fully remove them from assistive technology. -
The headings in your component are being used incorrectly. Since the
<h1>heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an<h2>heading since it is reusable and it will give each heading the same level of importance. -
When creating buttons, you can only use one or another of an element to create it; you cannot combine them. For the challenge, your buttons will be built using an
Anchor Tag. -
Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
- A lot of the headaches and repeated properties can be be overcome by implementing a proper CSS Reset.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
