Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <section class="contenir"> with the main tag and the html must contain <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .contenir on the page using flexbox or grid, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .contenir on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
To center .contenir on the page using grid: body{ min-height: 100vh; display: grid; place-items: center; }
There is no need to give the body a padding value. Give the body a background-color of hsl(0,0, 95%).
Give .contenir a fixed max-width value for a responsive content instead of a percentage width value:
max-width: 600px
.Replace the height in .cards with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord