Vanza Setia• 27,795
@vanzasetia
Posted
Hello, Elizabeth! 👋
It's great to see you completing another challenge! 👏
Regarding the issue, I would recommend making the body element as the flex container to put the cards in the middle of the page. After that, set a max-width on the container of the cards element (the .cards element) to prevent the cards from becoming too large on widescreen.
Some recommendations from me.
- I recommend learning how to write a good alternative text for images. Alternative text should not be hyphenated (like code) and there's no need for the word "icon". Also, not all images need alternative text.
- I would not suggest changing the
htmlor the:rootfont size. It can cause huge accessibility implications for those users with different font sizes or zoom requirements. I suggest reading this article by Josh Comeau where he tells about the problem of the 62.5% trick (and more!). Also, I recommend reading what an accessibility expert (Grace Snow) has said about it.
That's it! Hope this helps.
0
