Design comparison
Solution retrospective
No big secrets, made with flexbox and a query to change flex-direction on desktop. All feedback is welcome!
Community feedback
- @Sdann26Posted over 2 years ago
Hi Roberto!
Your
sr-only
has a problem, based on the information on thefreeCodeCamp
page we have the following:display: none; or visibility: hidden; hides content for everyone, including screen reader users.
They recommend using:
.sr-only { position: absolute; left: -10000px; width: 1px; height: 1px; top: auto; overflow: hidden; }
By the way, remove the type
button
from youra
links because they are not part of its attributes.Otherwise I have nothing to say, the design is perfect, good luck :D!
Marked as helpful1@RyukioMiyamotoPosted over 2 years ago@Sdann26 Thank you so much! I was trying to figure how to fix the sr-only cuz the website was pointing it out as an issue for me (missing h1). As for the type=button I don't know why I wrote it in the first place 🤦♂️ maybe I did it automatically because of the class name and forgot to fix it haha. Have a great week!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord