3 Columns preview card

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Karol, congrats on completing this challenge!

  Improve your html markup using meaningful tags to wrap the content, you can replace the div you’ve used for each card with <article>. Remember to wrap big blocks of content with semantic tags and never divs, use divs for small blocks.

  Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  ✌️ I hope this helps you and happy coding!

  0

  ---

  

  Karol•90

  @HekterekPosted about 2 years ago

  @correlucas Hi Lucas :)

  You are right with those articles. Somethimes i forget these tags. But i'm going to do my best for improve my code :)

  I have created the same class for three h1 or h2, just for reduce the code. In the future with a big projects, i will do like you say. Because i have more control on all content. This is just a little exercice :) i'm learning very fast :)

  Thanks for your answer !

  1

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @Hekterek Hey Karol! Ah thats fine! So I ask you sorry I didnt knew that! Keep it up

  0