Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3 columns challenge using HTML and CSS

@MelissaSauve

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I really enjoyed this challenge!!

Anny feedbacks are welcome.

Community feedback

Lucas 👾 104,420

@correlucas

Posted

👾Hello Melissa, congratulations for your solution!

Your component is really good done and match all the design specs. I liked a lots the work you've done here.

I've some tips for your:

ALIGN THE COMPONENT TO THE CENTER

body {
    min-height: 100vh;
    background-color: hsl(0, 0%, 95%);
    display: flex;
    align-items: center;
    justify-content: center;
    flex-direction: column;
}

ADD THE CORRECT VALUE FOR THE ROUNED BORDERS

.sedans {
    border-radius: 12px 0 0 12px;
}

Hope it helps and happy coding!

Marked as helpful

0

@MelissaSauve

Posted

@correlucas thank you 😊 for the border-radius I just liked it more with a larger radius!

1
PhoenixDev22 16,950

@PhoenixDev22

Posted

Hello @MelissaSauve,

Congratulation on completing another frontend mentor challenge

Great work! I have some suggestions regarding your solution:

HTML

  • You can use the <main> landmark to wrap the body content (which is the three cards). Use the <footer> landmark to wrap the attribution, as using landmarks is important to improve navigation experience on your site for users of assistive technology
  • About <h1>it is recommended not to have more than one h1 on the page . Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility. You can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech). Then you can use <h2> instead of those <h1>.
  • Images must have alt attribute. In this challenge , all the images are decorative. For any decorative images, each img tag should have empty alt="" as you did and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images .
  • Don't capitalise in html, let css text transform take care of that. Remember screen readers won't be able to Read capitalised text as they will often read them letter by letter thinking they are acronyms.

Overall, your solution is great. Hopefully this feedback helps.

Marked as helpful

0

@MelissaSauve

Posted

@PhoenixDev22 thank you that's verry helpful! I'm verry new with all of this so there are some things that I don't think about I'm gone try to apply them in the future!!

1
PhoenixDev22 16,950

@PhoenixDev22

Posted

@MelissaSauve You’re welcome and happy to help. Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord