3 columns card using BEM and flexbox

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Great work with this one. Regarding the solution you submitted, I think you should know the following notes…

  • There is a possibility to refactor this part...

   <div class="card__heading">
            <h2>Sedans</h2>
          </div>
  
          <div class="card__text">
            <p>...</p>
          </div>
  
          <div class="btn cta">
            Learn More
          </div>
  
  Into:
   <section class="card__heading">
            <h2>Sedans</h2>
            <p class="card__text">...</p>
          <button class="btn cta"> Learn More</button>
  </section>
  

  • Clean the whitespaces in the code
  • Modify the margin in .three-column-card rule set into margin: 0 auto;

  Other than that...

  • Great use in using root variables for styling in the CSS file
  • Proper usage in sizing the elements
  • The button have proper hover state individually
  • Great job in using media queries which makes the project responsive
  • The details are on point based on the original design

  Above all, The project is awesome! Keep it up!

  Marked as helpful

  2

  ---

  

  Victor•290

  @cervantesdeveloperPosted over 2 years ago

  @RioCantre Thanks for your help, I'll take your advice and make some changes.

  0