3 column-preview-card

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Jesús Yadiel,

  Congratulation on finishing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • Page should contain a level-one heading. In this challenge , as it’s not a whole page, you can have<h1>visually hidden with sr-only.

  • In my opinion, the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images.

  • What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>.You should use an interactive element.

  Aside these, great job on this one . Hopefully this feedback helps.

  1