Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3 Column -> Responsive

@FrayIsmaelBR

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


comenten sobre mis errores quiero saber las cosas que debo mejorar se los agradecería mucho

Community feedback

PhoenixDev22 16,950

@PhoenixDev22

Posted

Hello Fray Ismael,

Excellent work! Congratulation on completing this challenge. I have some suggestions regarding your solution if you don't mind:

HTML

  • You can use the <main> landmark to wrap the body content (which is the three cards). Use the <footer> landmark to wrap the attribution, as using landmarks is important to improve navigation experience on your site for users of assistive technology
  • You can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech). Page should have one level heading.
  • In this challenge , all the images are decorative. For any decorative images, each img tag should have empty alt="" as you did and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images . You have used the same images in each column.
  • There are some extra div’s , they have to be removed.
  • It's not recommended to set height to component, let the content of the component define the height.

Aside these, your solution is good. Hopefully this feedback helps

Marked as helpful

0

@AlejandroArigon

Posted

Buenas! muy buen proyecto, lo que note es que usaste la misma imagen del luxury para las 3 tarjetas. Fuera de eso lo hiciste bien, saludos!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord