3 Column -> Responsive

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Fray Ismael,

  Excellent work! Congratulation on completing this challenge. I have some suggestions regarding your solution if you don't mind:

  HTML

  • You can use the <main> landmark to wrap the body content (which is the three cards). Use the <footer> landmark to wrap the attribution, as using landmarks is important to improve navigation experience on your site for users of assistive technology

  • You can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech). Page should have one level heading.

  • In this challenge , all the images are decorative. For any decorative images, each img tag should have empty alt="" as you did and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images . You have used the same images in each column.

  • There are some extra div’s , they have to be removed.

  • It's not recommended to set height to component, let the content of the component define the height.

  Aside these, your solution is good. Hopefully this feedback helps

  Marked as helpful

  0
• 

  Alejandro Arigon•110

  @AlejandroArigonPosted over 2 years ago

  Buenas! muy buen proyecto, lo que note es que usaste la misma imagen del luxury para las 3 tarjetas. Fuera de eso lo hiciste bien, saludos!

  0